Main return 0 #189
Merged
Main return 0 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiwei
reviewed
May 16, 2024
cl/compile.go
Outdated
| @@ -246,10 +250,13 @@ func (p *context) compileFuncDecl(pkg llssa.Package, f *ssa.Function) (llssa.Fun | |||
| argc := types.NewParam(token.NoPos, pkgTypes, "", types.Typ[types.Int32]) | |||
| argv := types.NewParam(token.NoPos, pkgTypes, "", argvTy) | |||
| params := types.NewTuple(argc, argv) | |||
| sig = types.NewSignatureType(nil, nil, nil, params, nil, false) | |||
| ret := types.NewParam(token.NoPos, pkgTypes, "", types.Typ[types.Int]) | |||
There was a problem hiding this comment.
main func return c int, not go int.
cl/compile.go
Outdated
| @@ -779,6 +786,10 @@ func (p *context) compileInstr(b llssa.Builder, instr ssa.Instruction) { | |||
| results[i] = p.compileValue(b, r) | |||
| } | |||
| } | |||
| if p.inMain(instr) { | |||
| results = make([]llssa.Expr, 1) | |||
| results[0] = p.prog.IntVal(0, p.prog.Int()) | |||
There was a problem hiding this comment.
use prog.CInt() instead of prog.Int()
xushiwei
reviewed
May 17, 2024
cl/compile.go
Outdated
| @@ -237,7 +241,7 @@ func (p *context) compileFuncDecl(pkg llssa.Package, f *ssa.Function) (llssa.Fun | |||
| ctx := makeClosureCtx(pkgTypes, f.FreeVars) | |||
| sig = llssa.FuncAddCtx(ctx, sig) | |||
| } else { | |||
| if debugInstr { | |||
| if debugInstr && sig != nil && sig.Recv() != nil { | |||
|
[Git-flow] Hi @tsingbx, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.