Fix WAV pop sound after seek with unknown chunk in header #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an unknown chunk is reached, the bytes that hold the chunk size weren't added to the total header size. After a seek to the start of the file, the seek position would end up before the sample data, interpreting part of the header as samples.
dusk125
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
The pop sound was caused by an error in the header size calculation. When a WAV file contained a unknown chunk, first the chunk type (4 bytes) is red, then the size (4 bytes) and after that is the chunk data. The 4 bytes indicating the size weren't added to the total header size. When seeking to the beginning of the sample data, it would seek to a position in the header before the data. The header was then parsed as sample data, which caused the pop.
Test file:
pop.zip
Can be reproduced with the speedy-player by changing the decoded file type to WAV.