[BSD] Further support in tests #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some quirks resulting from the current observer implementation. This only adds tests to check that other platforms won't be affected.
|
Failures appear not to be caused by this patch :-) |
|
Grr, can't create next PR before this is merged (kinda makes sense). Will create when (if!) that's done. FTR: the fixes for kqueue: CamilionEU@37f2f96 |
|
I restarted failed jobs. If they are green, I will merge for you to be able to work on next steps 💪 |
|
Ugh, the mac check is failing, unsure how/if I broke it :-( |
|
This is a random bug. I will tackle it later. Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some quirks resulting from the current observer implementation.
This only adds tests to check that other platforms won't be affected.