fix: SetContext covers value (#352)

* fix: SetContext covers value * chore: update mocks * Fix unit test * Fix unit test * Remove SetContext * chore: update mocks --------- Co-authored-by: hwbrzzl <hwbrzzl@users.noreply.github.com>
goravel · Nov 21, 2023 · e91df53 · e91df53
1 parent 50ecec9
commit e91df53
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 25 deletions.
diff --git a/auth/auth_test.go b/auth/auth_test.go
@@ -80,10 +80,6 @@ func (mc *Context) Response() http.ContextResponse {
 	return mc.response
 }
 
-func (mc *Context) SetContext(ctx http.Context) {
-	mc.ctx = ctx.Context()
-}
-
 func Background() http.Context {
 	return &Context{
 		ctx:      context.Background(),

diff --git a/contracts/http/context.go b/contracts/http/context.go
@@ -29,6 +29,4 @@ type Context interface {
 	Request() ContextRequest
 	// Response returns the ContextResponse
 	Response() ContextResponse
-	// SetContext set the custom context
-	SetContext(ctx Context)
 }
diff --git a/http/context.go b/http/context.go
@@ -38,7 +38,3 @@ func (r *Context) Request() http.ContextRequest {
 func (r *Context) Response() http.ContextResponse {
 	return nil
 }
-
-func (r *Context) SetContext(ctx http.Context) {
-	r.Ctx = ctx.Context()
-}
diff --git a/http/context_test.go b/http/context_test.go
@@ -36,9 +36,3 @@ func (s *ContextTestSuite) TestRequest() {
 func (s *ContextTestSuite) TestResponse() {
 	s.Nil(s.ctx.Response())
 }
-
-func (s *ContextTestSuite) TestSetContext() {
-	ctx := NewContext()
-	s.ctx.SetContext(ctx)
-	s.Equal(ctx.Context(), s.ctx.Context())
-}
diff --git a/http/middleware/throttle_test.go b/http/middleware/throttle_test.go
@@ -283,10 +283,6 @@ func (r *TestContext) Response() contractshttp.ContextResponse {
 	return r.response
 }
 
-func (r *TestContext) SetContext(ctx contractshttp.Context) {
-	panic("do not need to implement it")
-}
-
 type TestRequest struct{}
 
 func (r *TestRequest) Header(key string, defaultValue ...string) string {

diff --git a/mocks/http/Context.go b/mocks/http/Context.go