fix: SetContext covers value #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 69.09% 69.08% -0.01%
==========================================
Files 147 147
Lines 9924 9922 -2
==========================================
- Hits 6857 6855 -2
Misses 2598 2598
Partials 469 469 ☔ View full report in Codecov by Sentry. |
devhaozi
reviewed
Nov 20, 2023
go.mod
Outdated
Comment on lines
47
to
48
| require github.com/teivah/onecontext v1.3.0 // indirect | ||
|
|
There was a problem hiding this comment.
Q: This package lacks maintenance and has less Stars, can we use self-implementation?
devhaozi
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
✅ Checks
ℹ Additional Information