feat: [#347] Switch logging channels on runtime #482
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 69.70% 69.53% -0.17%
==========================================
Files 174 174
Lines 10721 10744 +23
==========================================
- Hits 7473 7471 -2
- Misses 2681 2704 +23
- Partials 567 569 +2 β View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 69.89% 69.99% +0.10%
==========================================
Files 175 175
Lines 10795 10815 +20
==========================================
+ Hits 7545 7570 +25
+ Misses 2683 2678 -5
Partials 567 567 β View full report in Codecov by Sentry. |
log/application.go
Outdated
| channelPath := "logging.channels." + channel | ||
| driver := r.config.GetString(channelPath + ".driver") | ||
|
|
||
| if driver == log.StackDriver { | ||
| color.Red().Println("stack driver can't include self channel") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
We may don't need to add this limitation, registerHook will handle the logic.
There was a problem hiding this comment.
No, registerHook won't handle it. registerHook only checks if stack.channels refers to itself again. Since the stack function doesn't add channels into the config, it will not detect it.
There was a problem hiding this comment.
The stack function doesn't add channels into the config? Do you mean this?
The method facades.Log().Stack([]string{"stack", "single"}) is allowed, you seem to be missing something?
There was a problem hiding this comment.
Oh, sorry, I was mistaking the channel for the driver.
Closes goravel/goravel#347
π Description
β Checks
βΉ Additional Information