-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [#347] Switch logging channels on runtime #482
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 69.70% 69.53% -0.17%
==========================================
Files 174 174
Lines 10721 10744 +23
==========================================
- Hits 7473 7471 -2
- Misses 2681 2704 +23
- Partials 567 569 +2 β View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 69.89% 69.99% +0.10%
==========================================
Files 175 175
Lines 10795 10815 +20
==========================================
+ Hits 7545 7570 +25
+ Misses 2683 2678 -5
Partials 567 567 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, please optimize test cases.
log/application.go
Outdated
channelPath := "logging.channels." + channel | ||
driver := r.config.GetString(channelPath + ".driver") | ||
|
||
if driver == log.StackDriver { | ||
color.Red().Println("stack driver can't include self channel") | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may don't need to add this limitation, registerHook
will handle the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, I was mistaking the channel for the driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Closes goravel/goravel#347
π Description
β Checks
βΉ Additional Information