Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SymfonyHttpClient file configuration #177

Merged
merged 1 commit into from
May 11, 2021

Conversation

nlemoine
Copy link
Contributor

@nlemoine nlemoine commented May 11, 2021

Unfortunately, current implementation does not allow to use SymfonyHttpClient in the config file.

This PR decouples the http object creation logic from the config parsing.

However, there's still some inconsistencies because Config object properties and cli/file parameters are being merged/mixed up/not consistently named (temp_dir / webAllowInsecure).

@nlemoine
Copy link
Contributor Author

Maybe bringing a private method like getConfigOrParameter with parameter taking precedence over config file value would solve this?

@gordalina gordalina merged commit 9f44d97 into gordalina:master May 11, 2021
@gordalina gordalina changed the title Allow SymfonyHttpClient config in file Add SymfonyHttpClient file configuration May 11, 2021
@gordalina
Copy link
Owner

Thank you for your contribution! Released in 6.3.0

@nlemoine
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants