Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method tags for proxy classes #206

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add method tags for proxy classes #206

merged 1 commit into from
Oct 20, 2022

Conversation

myfluxi
Copy link
Contributor

@myfluxi myfluxi commented Jan 27, 2022

  • Also update the README with working instructions.

@myfluxi
Copy link
Contributor Author

myfluxi commented Mar 8, 2022

Any reason to ignore this minor change that helped me (and would probably help others who use this as a lib)?

@myfluxi
Copy link
Contributor Author

myfluxi commented Apr 8, 2022

image
image
image

@gordalina
Copy link
Owner

I'm integrating your commends on the README, thank you!

However, reagarding the method declaration in the docblock, CacheTool class implements multiple Proxies not just those two methods.

If you find a way to have phpdoc read those methods, then I'll happily accept your PR.

@myfluxi
Copy link
Contributor Author

myfluxi commented Jun 7, 2022

You are totally right, here is the full set of proxy methods. Thanks.

@myfluxi myfluxi changed the title Add method tags to satisfy IDE Add method tags for proxy classes Jun 7, 2022
@myfluxi
Add method tags for proxy classes
456583d 
* Satisfies IDE and static code quality tools such as PHPStan
@myfluxi
Copy link
Contributor Author

myfluxi commented Jun 8, 2022

Good to go now.

For reference, please see i.e. the nette Safe repo here: https://github.com/nette/safe/blob/master/src/Safe.php

@gordalina gordalina merged commit 525204e into gordalina:main Oct 20, 2022
@gordalina
Copy link
Owner

Released in v8.5.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordalina gordalina gordalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myfluxi @gordalina