Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rci input enhancements #84

Merged
merged 11 commits into from
Feb 20, 2017
Merged

Rci input enhancements #84

merged 11 commits into from
Feb 20, 2017

Conversation

superpowers11
Copy link
Collaborator

@superpowers11 superpowers11 commented Feb 20, 2017

  • Photo upload and display (Issues Storing Images upon RCI Input #50 and Display images on checkout #79 ) are working
  • Styling is still pretty rough; there are plenty of improvements to be made in that area. But the functionality should be a go.
  • Note: I am saving the photos immediately on upload. I did not account for the case where a person wants to delete a photo. I figured, a person would have deleted the photo when they actually take it, not AFTER they've uploaded it. However, if we want to add the delete functionality later, we can work that in. It just seemed to add complexity that may not be necessary.

To test:

  • In the RciInput page, select the "Take Photo" option, pick a photo. It will be saved upon upload.
  • Then refresh the page. It should still appear.
  • Click on any one of the photo's you have uploaded, and a "modal" slider thingy should appear, allowing you to scroll through the photos.

@eanyanwu
Copy link
Member

🚅
0_0 We actually figured out picture upload! Wew...I think it is safe to say that it is smooth sailing from here on out.
Issues:

  • I think we will need to let users delete pictures. What if they mistakenly upload two pictures of the same damage? or an RA deems that a pictures isn't necessary?
  • We will need to find a way to resize the pictures before saving.
  • We also need to display them in a way that doesn't affect the rest of the page.
    Example below:

capture d ecran 2017-02-20 a 01 08 06

@eanyanwu
Copy link
Member

LGTM. I has reiviewed this in person with steph.

@eanyanwu eanyanwu merged commit 39bc938 into master Feb 20, 2017
@eanyanwu eanyanwu deleted the rci-input-enhancements branch February 21, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants