New User Privacy Setting (2024) #1042
Conversation
…rder to solve merging conflicts
|
If #937 is Obsolete, can you close it @ArabellaJi? |
| /// <param name="userPrivacy">Faculty Staff Privacy Decisions (see UserPrivacyUpdateViewModel)</param> | ||
| /// <returns></returns> | ||
| [HttpPut] | ||
| [Route("user_privacy")] |
There was a problem hiding this comment.
| [Route("user_privacy")] | |
| [Route("{username}/user_privacy")] |
This may be personal preference, but I think it's better to always refer to a unique resource identifier rather than assuming the current authenticated user -- especially when trying to follow rest architecture.
Another option would be [Route("me/user_privacy")] but I don't know that we use that elsewhere.
| Field = field; | ||
| VisibilityGroup = group; | ||
| } | ||
| public IEnumerable<string> Field { get; set; } |
There was a problem hiding this comment.
Why is Field an IEnumerable<string> here but just a string in UserPrivacyGetViewModel.cs?
If there is no reason and they should both be string, could these two models be merged into one?
| using Gordon360.Models.CCT; | ||
| using Gordon360.Models.ViewModels.RecIM; | ||
|
|
||
| namespace Gordon360.Models.ViewModels |
There was a problem hiding this comment.
This could probably be merged with one of the other models or both of them (see comment above)
|
|
||
| foreach (UserPrivacy_Settings row in privacy) | ||
| { | ||
| if (row.Visibility == "Private" || (row.Visibility == "FacStaff" && currentUserType != "fac")) |
There was a problem hiding this comment.
I might use an enum here instead of having string literals maintained in the code.
|
|
||
| foreach (UserPrivacy_Settings row in privacy) | ||
| { | ||
| if (row.Visibility == "Private" || (row.Visibility == "FacStaff" && currentUserType != "fac")) |
| var account = accountService.GetAccountByUsername(username); | ||
|
|
||
| // select all privacy settings | ||
| var privacy = context.UserPrivacy_Settings.Where(up_s => up_s.gordon_id == account.GordonID).Select(up_s => (UserPrivacyViewModel)up_s); |
There was a problem hiding this comment.
| var privacy = context.UserPrivacy_Settings.Where(up_s => up_s.gordon_id == account.GordonID).Select(up_s => (UserPrivacyViewModel)up_s); | |
| var privacy = context.UserPrivacy_Settings.Where(up_s => up_s.gordon_id == account.GordonID).Select<UserPrivacy_Settings, UserPrivacyViewModel>(u => u); |
I believe this can be cleaned up a bit to something like the following. It is clearer what is happening here IMO.
Make sure to test my syntax as I am not 100% sure.
|
Arabella, The most recent changes break the UI - the drop down menus no longer have Public/FacStaff/Private in them:
|
This PR is to replace the PR #937. PR 937 has too many merging conflicts, so I decide to start a new one.
UI: gordon-cs/gordon-360-ui#2031