User Privacy Settings #2031
Open
User Privacy Settings #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amos-cha
requested changes
Jul 15, 2023
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
src/components/Profile/components/PersonalInfoList/UpdateUserPrivacyDialog/index.jsx
Outdated
Show resolved
Hide resolved
ArabellaJi
changed the title
added 9 commits
July 18, 2023 08:48
…on-cs/gordon-360-ui into s23-fac-privacy-option-ui-2
|
handle merge conflicts then I'll review |
amos-cha
previously approved these changes
Jul 21, 2023
|
NOTE: Don't merge until Database and API is pushed and merged! |
bennettforkner
changed the title
amos-cha
requested changes
May 28, 2024
| @@ -43,7 +44,7 @@ const formatPhone = (phone) => { | |||
|
|
|||
| const PersonalInfoList = ({ myProf, profile, isOnline, createSnackbar }) => { | |||
| const [isMobilePhonePrivate, setIsMobilePhonePrivate] = useState( | |||
| Boolean(profile.IsMobilePhonePrivate && profile.MobilePhone !== PRIVATE_INFO), | |||
| Boolean(profile.IsMobilePhonePrivate || profile.MobilePhone === PRIVATE_INFO), | |||
There was a problem hiding this comment.
is this ever not a boolean where we need a cast?
| privateInfo={isMobilePhonePrivate} | ||
| myProf={myProf} | ||
| /> | ||
| ) : null; | ||
|
|
||
| let streetAddr = profile.HomeStreet2 ? <span>{profile.HomeStreet2}, </span> : null; | ||
|
|
||
| let combineHomeLocation = | ||
| profile.Country === 'United States of America' || !profile.Country |
There was a problem hiding this comment.
Suggested change
| profile.Country === 'United States of America' || !profile.Country | |
| profile.Country === 'United States of America' || !profile.Country |
Second time this line comes up. Potentially better to extract it into its own variable that is used both here and in the home variable below
Comment on lines
+1
to
+18
| // vite.config.ts | ||
| import react from "file:///nfs/users/arabella.ji/summer-practicum/gordon-360-ui/node_modules/@vitejs/plugin-react/dist/index.mjs"; | ||
| import { defineConfig, loadEnv, splitVendorChunkPlugin } from "file:///nfs/users/arabella.ji/summer-practicum/gordon-360-ui/node_modules/vite/dist/node/index.js"; | ||
| import viteTsconfigPaths from "file:///nfs/users/arabella.ji/summer-practicum/gordon-360-ui/node_modules/vite-tsconfig-paths/dist/index.mjs"; | ||
| var config = ({ mode }) => { | ||
| process.env = { ...process.env, ...loadEnv(mode, process.cwd()) }; | ||
| return defineConfig({ | ||
| build: { | ||
| target: "es2022" | ||
| }, | ||
| plugins: [react(), viteTsconfigPaths(), splitVendorChunkPlugin()], | ||
| server: { | ||
| port: parseInt(process.env.VITE_PORT ?? "5173"), | ||
| host: process.env.VITE_HOST ?? "localhost", | ||
| proxy: { | ||
| "/api": { | ||
| target: process.env.VITE_API_URL, | ||
| changeOrigin: true |
There was a problem hiding this comment.
what is this file and is it necessary to be added?
docs/Developer's Guide.md
Outdated
There was a problem hiding this comment.
Why is this file included in your PR? It seems unrelated to me.
|
Yea there are a lot of files from other peoples' branches in your PR. The issues will be connected to the branch, not the PR. My recommendation would be that you create a new branch based on git switch develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is the new PR for #1931. The reason for creating this new PR is that when I wanted to merge develop into my old branch, I mistakenly did a
git rebase developin that branch, which pushed some irrelevant changes and commits made by other people into that old branch. Even though those changes were not harmful, they could still lead to some confusion, so I decided to open this new branch and PR.Allow users to choose which phone numbers they would like to show in their profiles and some other privacy options.
Fixes #1308
Fixes #1897
API: gordon-cs/gordon-360-api#1042