Add recommended extensions and editor defaults #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russtuck
previously approved these changes
Jul 19, 2023
amos-cha
reviewed
Jul 21, 2023
| "files.autoSave": "off", | ||
| "debug.allowBreakpointsEverywhere": true, | ||
| "gitdoc.enabled": false | ||
| "editor.rulers": [100], |
There was a problem hiding this comment.
Suggested change
| "editor.rulers": [100], | |
| "editor.rulers": [80], |
is there a specific reason we have this at 100? I just noticed this, I thought most common best practice is 80?
There was a problem hiding this comment.
I assume it's because so much of the code was done with a 100 character limit that we'll just live with that. (80 and 100 are both fairly commonly adopted and justifiable limits. I don't know which is more common.) I'd personally prefer setting it to 80 and gradually adopting that as we make changes. But if Evan thinks that's too painful, I won't disagree. I am interested in his reasoning, especially if I've guessed wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the minimum recommended extensions for VS Code so that users will be prompted to install our linting extensions.
This should probably be complemented by updates to CI to error on Linter warnings.