Dark Mode Color Contrast #2311
Merged
Dark Mode Color Contrast #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-W-Hart
requested review from
jsenning,
russtuck,
EjPlatzer and
bennettforkner
and removed request for
amos-cha,
EjPlatzer,
jsenning and
russtuck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2136 Luke and I worked on fixing the contrast issues on dark mode below is an image for reference. We changed the mailing outline as well as the contrast text and secondary main color on dark mode to be ScottieCyan.
Also fixes tab underline, used to look like this...
Now looks like this...
