Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Improve CI tests #120

Closed
glyn opened this issue Jun 13, 2019 · 3 comments
Closed

Improve CI tests #120

glyn opened this issue Jun 13, 2019 · 3 comments
Labels
enhancement no-issue-activity stale

Comments

@glyn
Copy link

glyn commented Jun 13, 2019

#118 was introduced in spite of the CI checks for 66279a7 having passed.

Once #118 is fixed, I'd suggest submitting a (draft) PR which deliberately reintroduces the same bug and working on getting CI to fail in that case.
glyn added a commit to glyn/godownloader that referenced this issue Jun 13, 2019
@glyn
Test only - do not merge
12362b3 
See goreleaser#120
@glyn glyn mentioned this issue Jun 13, 2019
Closed
@glyn
Copy link
Author

glyn commented Jun 13, 2019

I spent a few minutes trying to reproduce the problem locally in order to add a CI test, but I couldn't get it to fail even after reverting to 66279a7. I'm leaving this to someone who is familiar with the code or has more time.

@github-actions
Copy link

github-actions bot commented Oct 5, 2019

Stale issue message

@github-actions
Copy link

github-actions bot commented Dec 5, 2019

This issue seems be stale, will auto-close soon.

@github-actions github-actions bot added the stale label Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement no-issue-activity stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glyn @caarlos0