Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images listed twice in release #1133

Closed
Luit opened this issue Sep 3, 2019 · 1 comment · Fixed by #1134
Closed

Docker images listed twice in release #1133

Luit opened this issue Sep 3, 2019 · 1 comment · Fixed by #1134
Labels
bug Something isn't working

Comments

@Luit
Copy link
Contributor

Luit commented Sep 3, 2019

Describe the bug

Since v0.115.0 and caused by #1110 the Release body contains the full listing of Docker images twice.

To Reproduce

Release with some Docker images present (see this repo's releases).

Expected behavior

Each docker image should be mentioned only once. The change in #1110 caused duplicate DockerImage artifacts to be present after Publish, causing double listing. As the change made the artifacts all pointers, the artifact passed to the dockerPush function will be edited in place, as well as being added after the edit.

I'll make a pull request for this, which will copy the Artifact before adding it.
@Luit Luit added the bug Something isn't working label Sep 3, 2019
Luit added a commit to Luit/goreleaser that referenced this issue Sep 3, 2019
@Luit
fix: copy into DockerImage Artifact
1bc2332 
Since goreleaser#1110 the artifacts are passed by reference, causing the previous
code to edit the Artifact in place, _and_ add it to the list.

Fixes: goreleaser#1133
@Luit Luit mentioned this issue Sep 3, 2019
Merged
caarlos0 pushed a commit that referenced this issue Sep 3, 2019
@Luit @caarlos0
fix: copy into DockerImage Artifact (#1134)
705f66d 
Since #1110 the artifacts are passed by reference, causing the previous
code to edit the Artifact in place, _and_ add it to the list.

Fixes: #1133
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: copy into DockerImage Artifact Luit/goreleaser
1 participant
@Luit