Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pointer to artifact #1110

Merged
merged 1 commit into from Aug 12, 2019
Merged

refactor: pointer to artifact #1110

merged 1 commit into from Aug 12, 2019

Conversation

caarlos0
Copy link
Member

part of #1084

just to make things easier to review there :)

@caarlos0
refactor: pointer to artifact
c5de451 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 requested a review from mavogel August 12, 2019 12:52
@codecov-io
Copy link

codecov-io commented Aug 12, 2019 •
edited

Codecov Report

Merging #1110 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          57       57           
  Lines        2969     2969           
=======================================
  Hits         2488     2488           
  Misses        401      401           
  Partials       80       80
Impacted Files Coverage Δ
internal/pipe/release/release.go 90.12% <100%> (ø) ⬆️
internal/tmpl/tmpl.go 100% <100%> (ø) ⬆️
internal/pipe/archive/archive.go 96.25% <100%> (ø) ⬆️
internal/pipe/docker/docker.go 92.5% <100%> (ø) ⬆️
internal/pipe/scoop/scoop.go 88.63% <100%> (ø) ⬆️
internal/artifact/artifact.go 83.62% <100%> (ø) ⬆️
internal/http/http.go 91.44% <100%> (ø) ⬆️
internal/pipe/sign/sign.go 94.8% <100%> (ø) ⬆️
internal/pipe/checksums/checksums.go 100% <100%> (ø) ⬆️
internal/builders/golang/build.go 98.42% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c67521...c5de451. Read the comment docs.

mavogel
mavogel approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@mavogel mavogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit b477ffa into master Aug 12, 2019
@caarlos0 caarlos0 deleted the artifact-pointer branch August 12, 2019 20:44
@Luit Luit mentioned this pull request Sep 3, 2019
Closed
Luit added a commit to Luit/goreleaser that referenced this pull request Sep 3, 2019
@Luit
fix: copy into DockerImage Artifact
1bc2332 
Since goreleaser#1110 the artifacts are passed by reference, causing the previous
code to edit the Artifact in place, _and_ add it to the list.

Fixes: goreleaser#1133
@Luit Luit mentioned this pull request Sep 3, 2019
Merged
caarlos0 pushed a commit that referenced this pull request Sep 3, 2019
@Luit @caarlos0
fix: copy into DockerImage Artifact (#1134)
705f66d 
Since #1110 the artifacts are passed by reference, causing the previous
code to edit the Artifact in place, _and_ add it to the list.

Fixes: #1133
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mavogel mavogel mavogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caarlos0 @codecov-io @mavogel