Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build id #1008

Merged
merged 4 commits into from
Apr 14, 2019
Merged

feat: build id #1008

merged 4 commits into from
Apr 14, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 14, 2019

this is the first step to achieve multiple archives: we need to be able to identify builds.

The binary name alone is not a good idea, as the user may have different build configs depending on GOOS for example, so an ID field was added.

This is a breaking change: if the user has multiple builds with the same binary name the release will now fail.

refs #705

@codecov-io
Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #1008 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   88.12%   88.15%   +0.02%     
==========================================
  Files          52       52              
  Lines        2518     2524       +6     
==========================================
+ Hits         2219     2225       +6     
  Misses        236      236              
  Partials       63       63
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/build/build.go 97.43% <100%> (+0.17%) ⬆️
internal/builders/golang/build.go 98.34% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a971c0...60697b4. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants