Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.13 #1141

Closed
wants to merge 4 commits into from

Conversation

@chenrui333
Copy link

commented Sep 8, 2019

Relates to brew formula upgrade: Homebrew/homebrew-core#43969

Previous efforts: #1135

@chenrui333

This comment has been minimized.

Copy link
Author

commented Sep 8, 2019

Added change from #1138

@chenrui333 chenrui333 force-pushed the chenrui333:go-1.13 branch from f6f4ba0 to db7e925 Sep 8, 2019

defer back()
assert.NoError(t, releaseProject(testParams()))
}
// func TestReleaseProject(t *testing.T) {

This comment has been minimized.

Copy link
@caarlos0

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Sep 9, 2019

Author

Could not figure out why the test did not get passed. So I did the comment out it.

This comment has been minimized.

Copy link
@caarlos0

caarlos0 Sep 9, 2019

Member

I'll investigate it later today :)

Thanks for the PR btw 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.