Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pkg/errors.Wrap with fmt.Errorf #1812

Merged
merged 5 commits into from Sep 21, 2020
Merged

refactor: replace pkg/errors.Wrap with fmt.Errorf #1812

merged 5 commits into from Sep 21, 2020

Conversation

caarlos0
Copy link
Member

using the "new" way of wrapping errors.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Sep 20, 2020
@caarlos0 caarlos0 self-assigned this Sep 20, 2020
@vercel
Copy link

vercel bot commented Sep 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/lop2dwqup
✅ Preview: https://goreleaser-git-error.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2020
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #1812 into master will not change coverage.
The diff coverage is 56.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1812   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files          72       72           
  Lines        3692     3692           
=======================================
  Hits         2991     2991           
  Misses        580      580           
  Partials      121      121           
Impacted Files Coverage Δ
internal/git/config.go 100.00% <ø> (ø)
internal/pipe/brew/brew.go 78.08% <0.00%> (ø)
internal/pipe/publish/publish.go 75.00% <0.00%> (ø)
internal/pipe/snapcraft/snapcraft.go 78.36% <0.00%> (ø)
internal/pipe/blob/upload.go 72.13% <27.27%> (ø)
internal/artifact/artifact.go 77.22% <50.00%> (ø)
internal/builders/golang/build.go 94.11% <50.00%> (ø)
internal/pipe/git/git.go 87.91% <50.00%> (ø)
internal/pipe/release/release.go 89.18% <50.00%> (ø)
internal/pipe/nfpm/nfpm.go 92.00% <66.66%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee540c6...6c61deb. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview September 21, 2020 13:13 Inactive
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good cleanup!

@vercel vercel bot temporarily deployed to Preview September 21, 2020 15:59 Inactive
@radeksimko
Copy link
Member

I think there's a bug somewhere though, based on the failing test.

@radeksimko radeksimko self-requested a review September 21, 2020 16:11
@caarlos0
Copy link
Member Author

Seems related to gitea, will take a look... but I think it was introduced by #1807

@vercel vercel bot temporarily deployed to Preview September 21, 2020 17:33 Inactive
@kodiakhq kodiakhq bot merged commit 65ffbf1 into master Sep 21, 2020
@kodiakhq kodiakhq bot deleted the error branch September 21, 2020 17:47
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants