Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression on nil pointer check #2533

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Sep 28, 2021

Signed-off-by: Engin Diri engin.diri@mail.schwarz

fixes #2532

Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2533 (8f81661) into master (c4b23fa) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2533   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files          93       93           
  Lines        6444     6444           
=======================================
  Hits         5378     5378           
  Misses        910      910           
  Partials      156      156           
Impacted Files Coverage Δ
internal/client/github.go 33.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b23fa...8f81661. Read the comment docs.

@caarlos0
Copy link
Member

Good catch, thanks!

@caarlos0 caarlos0 merged commit 8881328 into goreleaser:master Sep 28, 2021
@dirien dirien deleted the nil branch September 28, 2021 12:15
dirien pushed a commit to dirien/goreleaser that referenced this pull request Sep 28, 2021
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: panic on publish when no Github token is set
2 participants