Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make each changelog commit a list item #2695

Merged
merged 1 commit into from Nov 24, 2021
Merged

Conversation

caarlos0
Copy link
Member

Made a few changes here:

  • commits are now list items (someone asked this, I always wanted to do this, don't see why not as it looks better)
  • refactor some code from feat: CHANGELOG categories #2670
    • compile each regex only once
    • rename method
    • check if regex is valid and error otherwise
      • also added a test for this

cc/ @dirien


example output:
## Changelog

### New Features

* 81c53073a4d4b638cec836ccb6cee78052695b3a: feat(ci): add cosign public key to releases (#2636) (@erkanzileli)
* a94e28b77c40d0ff483f618e77d2defdc637e54f: feat(deps): bump golang from 1.17.2-alpine to 1.17.3-alpine (#2632) (@dependabot[bot])

### Bug fixes

* 1e718d2db0a612fe79e25292889c9ca10a97e563: Revert "fix: armv7 on linux is usually armv7l" (@caarlos0)
* c958e4cc5e18073116881a7dd79355ca9197871a: fix: changelog is too long (#2661) (@dirien)

### Other work

* 048557efdb35d87f628ff1206ebff48b44229075: Merge remote-tracking branch 'origin/main' (@caarlos0)
* cf73ede93248e0de9a3a1cc6e5d12f03d4492b7d: refactor: improve changelog code (@caarlos0)

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2021
@caarlos0 caarlos0 self-assigned this Nov 24, 2021
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 24, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Nov 24, 2021
@caarlos0 caarlos0 added this to the v1.1.0 milestone Nov 24, 2021
@caarlos0 caarlos0 requested a review from a team November 24, 2021 02:30
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2695 (2dcbc0a) into main (419b6fc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files         103      103              
  Lines        7883     7882       -1     
==========================================
- Hits         6682     6681       -1     
  Misses        985      985              
  Partials      216      216              
Impacted Files Coverage Δ
internal/pipe/changelog/changelog.go 91.35% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419b6fc...2dcbc0a. Read the comment docs.

Copy link
Contributor

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Good changes! 👍🏻

Board automation moved this from In progress to Reviewer approved Nov 24, 2021
@caarlos0 caarlos0 merged commit df0c31d into main Nov 24, 2021
@caarlos0 caarlos0 deleted the itemnize-changelog branch November 24, 2021 12:11
Board automation moved this from Reviewer approved to Done Nov 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants