Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store artifact list into dist/artifacts.json #2715

Merged
merged 3 commits into from
Dec 1, 2021
Merged

feat: store artifact list into dist/artifacts.json #2715

merged 3 commits into from
Dec 1, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 1, 2021

closes #2714

@caarlos0
feat: store artifact list into dist/artifacts.json
03c1c70 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added this to the v1.2.0 milestone Dec 1, 2021
@caarlos0 caarlos0 self-assigned this Dec 1, 2021
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2021
@caarlos0 caarlos0 requested a review from a team December 1, 2021 00:08
@caarlos0
chore: fmt
0a4f08f 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview December 1, 2021 00:12 Inactive
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited

Codecov Report

Merging #2715 (647ffc0) into main (535a383) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
- Coverage   84.90%   84.90%   -0.01%     
==========================================
  Files         104      105       +1     
  Lines        7884     7901      +17     
==========================================
+ Hits         6694     6708      +14     
- Misses        976      978       +2     
- Partials      214      215       +1
Impacted Files Coverage Δ
internal/pipe/artifacts/artifacts.go 70.00% <70.00%> (ø)
cmd/build.go 97.69% <100.00%> (ø)
internal/artifact/artifact.go 98.35% <100.00%> (+0.01%) ⬆️
internal/golden/golden.go 81.57% <100.00%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535a383...647ffc0. Read the comment docs.

wesleimp
wesleimp approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@vercel vercel bot temporarily deployed to Preview December 1, 2021 03:33 Inactive
dirien
dirien approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Again, a very cool feature!

@caarlos0 caarlos0 merged commit ecb800a into main Dec 1, 2021
@caarlos0 caarlos0 deleted the artifacts.json branch December 1, 2021 12:54
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 1, 2021
@rpothier rpothier mentioned this pull request Dec 23, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

@wesleimp wesleimp wesleimp approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Machine readable output
3 participants
@caarlos0 @dirien @wesleimp