small improvements #321
small improvements #321
Conversation
|
@caarlos0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ElOpio, @client9 and @lucapette to be potential reviewers. |
pipeline/snapcraft/snapcraft.go
Outdated
| snap := filepath.Join( | ||
| ctx.Config.Dist, | ||
| metadata.Name+"_"+metadata.Version+"_"+arch+".snap", | ||
| ) |
There was a problem hiding this comment.
This will fail because we are setting cmd.Dir before running the command, so it will try to put the .snap in an unexisting dist dir, in the wrong path.
It will work with this diff:
http://paste.ubuntu.com/25233953/
There was a problem hiding this comment.
thanks @ElOpio, just pushed the fix
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 94.12% 94.51% +0.38%
==========================================
Files 27 27
Lines 1090 1093 +3
==========================================
+ Hits 1026 1033 +7
+ Misses 46 42 -4
Partials 18 18
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I noticed that the final artifact was in a subfolder inside dist, different from the other pipes, so I change that. (see https://travis-ci.org/goreleaser/goreleaser/builds/260157591#L891)
I also dealt with a possible error while linking files.
Finally, I passed gometalinter again on the code (disabled on build because it always time out on travis for some reason) and fixed the things it complained about 👍
cc/ @ElOpio