Fix: Allow using double quotes for templates in Slack notifications #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
4 tasks
As noted in goreleaser#4556, when we're using a double quote, for use with a template variable or function, we receive a template parse error as the value needs to be unquoted. This provides a slightly hacky solution which is to unquote any quoted quotes. Closes goreleaser#4556.
jamietanna
force-pushed
the
defect/quoted-slack
branch
from
55f8a8e
to
d195133
Compare
jamietanna
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4555 +/- ##
==========================================
+ Coverage 83.75% 83.86% +0.11%
==========================================
Files 135 135
Lines 12919 12923 +4
==========================================
+ Hits 10820 10838 +18
+ Misses 1671 1656 -15
- Partials 428 429 +1 ☔ View full report in Codecov by Sentry. |
|
nice, thank you! |
|
Thanks very much 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #4556, when we're using a double quote, for use with a
template variable or function, we receive a template parse error as the
value needs to be unquoted.
This provides a slightly hacky solution which is to unquote any quoted
quotes.
Closes #4556.