Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor: split publish from packaging #816

Closed
wants to merge 4 commits into from
Closed

WIP: refactor: split publish from packaging #816

wants to merge 4 commits into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 2, 2018

this is the general idea I have for splitting the publishing part.

What we gain with that:

  • all the skip publish logic can be done in a single place
  • we can have better error handling (packaging vs publishing)

The general idea is:

  • artifact types will be basically duplicated (prefixed with something that tells that they can be published)
  • the Pipes will be split between building the thing and publishing it
  • the publish itself will also be a pipe (like the defaults pipe)

In the future, we may improve this further by having a Packager interface (or something like that), so the pipeline would be:

  • defaults
  • build
  • package
  • publish

Any thoughts?

@caarlos0 caarlos0 mentioned this pull request Oct 2, 2018
6 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant