refactor: add a method on Info to list files to copy to the package #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since iterating over the files to copy to the package is something that all package formats need, adding a central place for that logic reduces duplication. Also sort the list of files as a step toward making builds more reproducible.
caarlos0
reviewed
May 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 72.44% 73.30% +0.86%
==========================================
Files 6 6
Lines 519 517 -2
==========================================
+ Hits 376 379 +3
+ Misses 90 87 -3
+ Partials 53 51 -2
Continue to review full report at Codecov.
|
caarlos0
reviewed
May 13, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since iterating over the files to copy to the package is something that
all package formats need, adding a central place for that logic reduces
duplication.
Also sort the list of files as a step toward making builds more
reproducible.