Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture names in goreleaser #21

Closed
ncw opened this issue Mar 21, 2018 · 5 comments
Closed

Architecture names in goreleaser #21

ncw opened this issue Mar 21, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ncw
Copy link

ncw commented Mar 21, 2018

I've successfully managed to make .deb and .rpm for the rclone release with nfpm - hooray and thank you!

However I had a report that my 386 package wouldn't install.

I think that is because I put the architecture in as 386 (go style) whereas I think debian requires i386.

I can translate them easily enough, but then I was wondering if this should be something nfpm should do. I was also wondering if it affects goreleaser.

These are the translations I came up with when thinking about it

// Goarch to debian arch mapping
var goarchToDebian = map[string]string{
       "386":    "i386",
       "amd64":  "amd64",
       "arm":    "armhf",
       "arm64":  "arm64",
       "mips":   "mips",
       "mipsle": "mipsel",
}

What do you think?

@caarlos0
Copy link
Member

hmm, probably... on the rpm packager there is a fix for amd64 or something already... I think we can do the same for the deb :)

@caarlos0 caarlos0 added the bug Something isn't working label Mar 21, 2018
@caarlos0 caarlos0 self-assigned this Mar 21, 2018
caarlos0 added a commit that referenced this issue Mar 21, 2018
@caarlos0
Copy link
Member

check #22

@ncw
Copy link
Author

ncw commented Mar 22, 2018

Nice one - thank you very much :-)

I'll give this a go and report back

@caarlos0
Copy link
Member

fixed on #22

@caarlos0
Copy link
Member

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants