fix: race condition and remove unused code #273
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/1fniyypzm |
pull-request-size
bot
added
the
size/S
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
pull-request-size
bot
removed
the
size/S
pull-request-size
bot
added
the
size/M
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
pull-request-size
bot
removed
the
size/M
pull-request-size
bot
added
the
size/L
caarlos0
changed the title
| func (c *Content) WithFileInfoDefaults() { | ||
| if c.FileInfo == nil { | ||
| c.FileInfo = &ContentFileInfo{} | ||
| func (c *Content) WithFileInfoDefaults() *Content { |
There was a problem hiding this comment.
this method could be called by multiple threads at once, therefore we probably need to modify and return a copy instead.
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 69.82% 69.86% +0.03%
==========================================
Files 9 9
Lines 1097 1085 -12
==========================================
- Hits 766 758 -8
+ Misses 205 203 -2
+ Partials 126 124 -2
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
remove unused custom yaml parse and make some code a bit clearer...