Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deb release at end of version string #375

Merged

Conversation

kpenfound
Copy link
Contributor

Fix for #369

This moves info.Release to the end of the version string, effectively applying info.Prerelease and info.Metadata to the upstream version rather than the debian-revision

Effective change to the deb filename is:
Before:

  • Version: 1.2.3~beta+abc
  • Release: 2
  • Output filename: foo_1.2.3-2~beta+abc_amd64.deb

After

  • Version: 1.2.3~beta+abc
  • Release: 2
  • Output filename: foo_1.2.3~beta+abc-2_amd64.deb

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2021
@vercel
Copy link

vercel bot commented Oct 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/9ZvkeSSHVKpAevRT1Po317TcjR9t
✅ Preview: https://nfpm-git-fork-kpenfound-fixdebprereleaserelea-50a4fd-goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview October 9, 2021 15:55 Inactive
@kpenfound kpenfound changed the title fix: release at end of version string fix: deb release at end of version string Oct 9, 2021
@vercel vercel bot temporarily deployed to Preview October 10, 2021 17:44 Inactive
@caarlos0 caarlos0 merged commit 4210500 into goreleaser:master Oct 10, 2021
@caarlos0
Copy link
Member

closes #369

@caarlos0
Copy link
Member

thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants