Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deb version order in control #498

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

kpenfound
Copy link
Contributor

This should have been caught in #375 but I missed it.

The version string when using Release is correct in the filename, but incorrect in the control file.

Here's the debian docs on the control file's version

Before:
Filename: foo_1.2.3~pre+meta-2_amd64.deb
control version: 1.2.3-2~pre+meta

After:
Filename: foo_1.2.3~pre+meta-2_amd64.deb
control version: 1.2.3~pre+meta-2

task ci 🚀

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #498 (5a06a5a) into main (0310042) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files          16       16           
  Lines        1916     1916           
=======================================
  Hits         1267     1267           
  Misses        510      510           
  Partials      139      139           
Impacted Files Coverage Δ
deb/deb.go 70.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0310042...5a06a5a. Read the comment docs.

@caarlos0 caarlos0 added the bug Something isn't working label Apr 22, 2022
@caarlos0 caarlos0 merged commit 170bf81 into goreleaser:main Apr 22, 2022
@caarlos0
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants