Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has the minimum Go version (intentionally) changed? #820

Closed
2 tasks done
atc0005 opened this issue May 9, 2024 · 4 comments
Closed
2 tasks done

Has the minimum Go version (intentionally) changed? #820

atc0005 opened this issue May 9, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@atc0005
Copy link

atc0005 commented May 9, 2024

What happened?

Minimum Go version changed from 1.19 to 1.22 via:

This was surprising since Go 1.21 was set as the minimum Go version in this commit:

I would have expected Go 1.21 to be the minimum Go version.

The contributing doc notes that Go 1.19 and newer is supported:

How can we reproduce this?

If you attempt to install nfpm via go install github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.37.0 using Go 1.21 you get this error:

go: github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.37.0: github.com/goreleaser/nfpm/v2@v2.37.0 requires go >= 1.22 (running go 1.21.10; GOTOOLCHAIN=local)

nfpm version

v2.36.1 builds/installs successfully using Go 1.21
v2.37.0 fails to build

Build error:

> `go: github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.37.0: github.com/goreleaser/nfpm/v2@v2.37.0 requires go >= 1.22 (running go 1.21.10; GOTOOLCHAIN=local)`

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

If the minimum Go version change is intentional then the https://github.com/goreleaser/nfpm/blob/main/CONTRIBUTING.md doc probably needs updating to reflect that, in which case the fix is to update that file instead of reverting the minimum version listed in this project's go.mod file.

@atc0005 atc0005 added the bug Something isn't working label May 9, 2024
@atc0005
Copy link
Author

atc0005 commented May 9, 2024

On a different note, many thanks for this tool!

@caarlos0
Copy link
Member

caarlos0 commented May 9, 2024

it wasn't intentional, no - must have slipped with some dep update... fixing!

thanks for letting me know 💜

caarlos0 added a commit that referenced this issue May 9, 2024
refs #820

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member

caarlos0 commented May 9, 2024

pushed new tag with the fixes, let me know if it works as expected now.

  • min go version is go1.21.
  • also updated contributing.md

@atc0005
Copy link
Author

atc0005 commented May 9, 2024

@caarlos0 That was fast!

nfpm v2.37.1 builds without issue using Go 1.21.

Thank you!

@atc0005 atc0005 closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants