Fix: Fix deb file path prefixes and md5sums file #218
Conversation
This patch ensures that all items contained in tar.gz files in Debian
packages have a relative path prefix, so the names all start with "./".
While this is not strictly required for a Debian package to function,
detecting a changed config file fails with an error messages similar to
the following:
tar: ./etc/default/conffilename: Not found in archive
It seems to fail extracting config files for checking if they have been
modified by the system administrator.
All reference documentation that I was able to find (e.g. in the Debian
Handbook[1]) shows that all paths contained in either data.tar.gz and
control.tar.gz have the prefix "./".
I've verified that with this change, config files works as expected.
[1] https://debian-handbook.info/browse/stable/packaging-system.html#sect.binary-package-structure
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/6forwzino |
pull-request-size
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 69.00% 68.99% -0.02%
==========================================
Files 7 7
Lines 926 932 +6
==========================================
+ Hits 639 643 +4
- Misses 178 179 +1
- Partials 109 110 +1
Continue to review full report at Codecov.
|
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request is based on #217 and ensures that files inside
.tar.gzfiles ofdebpackages adhere to the same path prefix convention as regular upstream Debian packages. I created this PR to fix the broken acceptance test in #217 which was caused by the fact thatdpkgin Ubuntu Docker images is configured to ignore changelog files but ONLY if we adhere to the path prefix conventions that are introduced in the PR.During debugging I also found a nasty bug when generating the
md5sumsfile if a changelog is added that results in a brokenmd5sumsfile. I included the fix and corresponding test in this PR because the changes were all lumped together after I was done debugging. Sorry for the mess.