Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix file collision detection with per-file packagers #303

Merged
merged 2 commits into from Feb 26, 2021

Conversation

erikgeiser
Copy link
Member

This PR fixes #302 by taking per-file packagers into account when detecting file destination collisions.

@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/Cu2tNddQqjeTDbMCN6PtsbaP2A7c
✅ Preview: https://nfpm-git-fork-erikgeiser-fix-collision-detection-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2021
@vercel vercel bot temporarily deployed to Preview February 26, 2021 21:23 Inactive
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #303 (46900e1) into master (4a81c34) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   70.18%   70.21%   +0.02%     
==========================================
  Files           9        9              
  Lines        1107     1108       +1     
==========================================
+ Hits          777      778       +1     
  Misses        204      204              
  Partials      126      126              
Impacted Files Coverage Δ
files/files.go 95.83% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a81c34...46900e1. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview February 26, 2021 21:39 Inactive
@caarlos0 caarlos0 added automerge bug Something isn't working labels Feb 26, 2021
@kodiakhq kodiakhq bot merged commit 6192474 into goreleaser:master Feb 26, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contents example with packager result in conflict
2 participants