Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable debian arm6 tests #414

Merged
merged 1 commit into from
Dec 4, 2021
Merged

fix: disable debian arm6 tests #414

merged 1 commit into from
Dec 4, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 4, 2021

shouldn't have merged #412

problem is when you request debian linux/arm/6, the arm7 image is given...

docker run --platform linux/arm/6 --rm  debian uname -a

it was working before because our test was wrong (arch was arm7 and testing against a arm7, thinking it was arm6)

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2021
@caarlos0 caarlos0 added the bug Something isn't working label Dec 4, 2021
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #414 (e174acd) into main (a261112) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files          15       15           
  Lines        1876     1876           
=======================================
  Hits         1252     1252           
  Misses        487      487           
  Partials      137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a261112...e174acd. Read the comment docs.

@caarlos0 caarlos0 merged commit b3d6c14 into main Dec 4, 2021
@caarlos0 caarlos0 deleted the armv6 branch December 4, 2021 20:12
@github-actions github-actions bot added this to the 2.11.0 milestone Dec 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant