Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support recommending and suggesting packages #5

Merged
merged 7 commits into from
Feb 18, 2018
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 18, 2018

@bpicode
Copy link

bpicode commented Feb 18, 2018

I think 'Recommends' is not supported by the rpm version you get from travis/apt.

@caarlos0 caarlos0 changed the title feat: support recommending packages feat: support recommending and suggesting packages Feb 18, 2018
@caarlos0
Copy link
Member Author

I think 'Recommends' is not supported by the rpm version you get from travis/apt.

yep, added some code to handle that...

@codecov-io
Copy link

codecov-io commented Feb 18, 2018

Codecov Report

Merging #5 into master will increase coverage by 1.62%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   69.38%   71.01%   +1.62%     
==========================================
  Files           3        3              
  Lines         245      276      +31     
==========================================
+ Hits          170      196      +26     
- Misses         38       40       +2     
- Partials       37       40       +3
Impacted Files Coverage Δ
nfpm.go 100% <ø> (ø) ⬆️
deb/deb.go 69.35% <100%> (+0.5%) ⬆️
rpm/rpm.go 69.34% <74.28%> (+3.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0f322...4d7ea97. Read the comment docs.

@caarlos0 caarlos0 merged commit 8bb63d1 into master Feb 18, 2018
@caarlos0 caarlos0 deleted the recommends branch February 18, 2018 22:05
caarlos0 added a commit to goreleaser/goreleaser that referenced this pull request Feb 18, 2018
@caarlos0
Copy link
Member Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should be able to do that "suggested packages" thing
3 participants