Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement dpkg-sig Package signing #515

Merged
merged 13 commits into from
Jun 12, 2022
Merged

feat: implement dpkg-sig Package signing #515

merged 13 commits into from
Jun 12, 2022

Conversation

caarlos0
Copy link
Member

continuing #508

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #515 (b217db6) into main (1eb3837) will increase coverage by 0.19%.
The diff coverage is 60.86%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   65.97%   66.16%   +0.19%     
==========================================
  Files          16       16              
  Lines        2019     2013       -6     
==========================================
  Hits         1332     1332              
+ Misses        537      533       -4     
+ Partials      150      148       -2     
Impacted Files Coverage Δ
internal/sign/pgp.go 65.31% <0.00%> (+1.38%) ⬆️
deb/deb.go 71.42% <63.63%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb3837...b217db6. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 30, 2022 13:09 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 30, 2022 13:34 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 30, 2022 13:37 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this May 30, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label May 30, 2022
@vercel vercel bot temporarily deployed to Preview May 30, 2022 13:39 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review May 30, 2022 14:50
Copy link
Member

@erikgeiser erikgeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR doesn't contain unit tests for the new signing method though. I don't think that's a problem because the PR does add acceptance tests but I like the unit tests because they are way faster and more convenient. But overall it's not a big deal and you could just merge it.

@caarlos0
Copy link
Member Author

@erikgeiser the unit tests were added in #508

main issue in this pr imo is that it does not actually verify the signing, as I couldn't find any way of doing it with a custom signature...

maybe @SasSwart knows a way?

@caarlos0 caarlos0 merged commit d1c1066 into main Jun 12, 2022
@caarlos0 caarlos0 deleted the SasSwart/main branch June 12, 2022 02:32
@github-actions github-actions bot added this to the 2.15.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants