-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement dpkg-sig Package signing #515
Conversation
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 65.97% 66.16% +0.19%
==========================================
Files 16 16
Lines 2019 2013 -6
==========================================
Hits 1332 1332
+ Misses 537 533 -4
+ Partials 150 148 -2
Continue to review full report at Codecov.
|
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This PR doesn't contain unit tests for the new signing method though. I don't think that's a problem because the PR does add acceptance tests but I like the unit tests because they are way faster and more convenient. But overall it's not a big deal and you could just merge it.
@erikgeiser the unit tests were added in #508 main issue in this pr imo is that it does not actually verify the signing, as I couldn't find any way of doing it with a custom signature... maybe @SasSwart knows a way? |
continuing #508