Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: archlinux prerelease #578

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix: archlinux prerelease #578

merged 1 commit into from
Nov 17, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 17, 2022 •
edited

closes #577

@caarlos0
fix: archlinux prerelease
a4cb1e9 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 17, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2022
@vercel vercel bot temporarily deployed to Preview November 17, 2022 01:31 Inactive
@caarlos0 caarlos0 added this to the v2.23.0 milestone Nov 17, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 17, 2022 01:31
@caarlos0 caarlos0 mentioned this pull request Nov 17, 2022
Closed
2 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #578 (a4cb1e9) into main (b15966c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   70.25%   70.30%   +0.05%     
==========================================
  Files          21       21              
  Lines        3133     3139       +6     
==========================================
+ Hits         2201     2207       +6     
  Misses        715      715              
  Partials      217      217
Impacted Files Coverage Δ
arch/arch.go 74.49% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@j-tai
Copy link
Contributor

j-tai commented Nov 17, 2022 •
edited

LGTM

Worth noting that we cannot add a delimiter between the version and the prerelease, because of the way versions are compared by vercmp(8):

1.2beta1 < 1.2
1.2_beta1 > 1.2
1.2.beta1 > 1.2

@caarlos0 caarlos0 merged commit 5f10dba into main Nov 17, 2022
@caarlos0 caarlos0 deleted the arch-prerelease branch November 17, 2022 12:50
@caarlos0 caarlos0 added the bug Something isn't working label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.

archlinux packager doesn't use prerelease option
2 participants
@caarlos0 @j-tai