Added Packager and Epoch tags #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `Maintainer` tag from deb as the `Packager` tag for rpm See goreleaser#57
caarlos0
reviewed
Jun 25, 2019
caarlos0
approved these changes
Jun 25, 2019
Adding a unit test for the epoch field and fixing the implementation of version number with epoch for deb packager. See goreleaser#57
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 5 5
Lines 493 493
=======================================
Hits 352 352
Misses 87 87
Partials 54 54
Continue to review full report at Codecov.
|
|
Thanks for the heads up! I'm new to the template system, and I see where I went wrong now. It's tested and fixed now! |
|
awesome, thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57