Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove space from asset name #674

Merged
merged 1 commit into from Jun 7, 2023
Merged

chore: remove space from asset name #674

merged 1 commit into from Jun 7, 2023

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jun 6, 2023

I checked GitHub Actions log, then it seems there is an space between nfpm_ and 2.30.0.

https://github.com/goreleaser/nfpm/actions/runs/5180574010/jobs/9334922406

• archives
    • creating                                       archive=dist/nfpm_ 2.30.0_Windows_arm64.zip
    • creating                                       archive=dist/nfpm_ 2.30.0_Windows_x86_64.zip
    • creating                                       archive=dist/nfpm_ 2.30.0_Linux_arm64.tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0_Linux_x86_[64](https://github.com/goreleaser/nfpm/actions/runs/5180574010/jobs/9334922406#step:13:65).tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0_Darwin_arm64.tar.gz

https://pkg.go.dev/text/template#hdr-Text_and_spaces

I guess GitHub may convert spaces in asset names to periods.

Test

I ran goreleaser release --snapshot --clean on my laptop and confirmed the bug has been fixed.

goreleaser release --snapshot --clean

AS IS

  • archives
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Linux_x86_64.tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Windows_x86_64.zip
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Darwin_arm64.tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Windows_arm64.zip
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/nfpm_ 2.30.0-SNAPSHOT-a72ecd2_Linux_arm64.tar.gz

TO BE

  • archives
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Windows_arm64.zip
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Linux_arm64.tar.gz
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Windows_x86_64.zip
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Darwin_arm64.tar.gz
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Linux_x86_64.tar.gz
    • creating                                       archive=dist/nfpm_2.30.0-SNAPSHOT-c4d9c64_Darwin_x86_64.tar.gz

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2023
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review June 6, 2023 23:46
@caarlos0 caarlos0 merged commit 3e5d930 into goreleaser:main Jun 7, 2023
1 check passed
@caarlos0
Copy link
Member

caarlos0 commented Jun 7, 2023

good catch, thank you!

@github-actions github-actions bot added this to the v2.27.0 milestone Jun 7, 2023
@suzuki-shunsuke suzuki-shunsuke deleted the patch-1 branch June 7, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants