Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unfork rpmpack. #688

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: unfork rpmpack. #688

merged 1 commit into from
Jul 10, 2023

Conversation

jarondl
Copy link
Contributor

@jarondl jarondl commented Jul 10, 2023

Go back to using upstream github.com/google/rpmpack instead of nfpm's forked version.

See #640

Go back to using upstream github.com/google/rpmpack instead of nfpm's
forked version.

See goreleaser#640
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 10, 2023
@caarlos0
Copy link
Member

thanks @jarondl! will wait for CI and merge 🤘

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #688 (6348db4) into main (90d060d) will decrease coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   75.86%   74.85%   -1.01%     
==========================================
  Files          14       10       -4     
  Lines        2962     2390     -572     
==========================================
- Hits         2247     1789     -458     
+ Misses        506      425      -81     
+ Partials      209      176      -33     
Impacted Files Coverage Δ
rpm/rpm.go 70.39% <ø> (ø)

@caarlos0 caarlos0 merged commit 10d7776 into goreleaser:main Jul 10, 2023
39 checks passed
@github-actions github-actions bot added this to the v2.27.0 milestone Jul 10, 2023
@caarlos0 caarlos0 modified the milestones: v2.27.0, 2.32.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants