Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpm): properly handle optional fields #809

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(rpm): properly handle optional fields #809

merged 1 commit into from
Apr 15, 2024

Conversation

caarlos0
Copy link
Member

closes #619

closes  #619

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2024
Copy link

Deploying nfpm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 680fefa
Status: ✅  Deploy successful!
Preview URL: https://db89ed48.nfpm.pages.dev
Branch Preview URL: https://rpm-optional.nfpm.pages.dev

View logs

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.17%. Comparing base (1667ef9) to head (680fefa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   72.13%   72.17%   +0.03%     
==========================================
  Files          20       20              
  Lines        2232     2235       +3     
==========================================
+ Hits         1610     1613       +3     
  Misses        438      438              
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 409b516 into main Apr 15, 2024
41 checks passed
@caarlos0 caarlos0 deleted the rpm-optional branch April 15, 2024 11:02
@github-actions github-actions bot added this to the 2.36.0 milestone Apr 15, 2024
@caarlos0 caarlos0 modified the milestones: 2.36.0, 2.37.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpm: packages with undefined values are written as empty strings
1 participant