fix: better handle files owned by the fs #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/M
Deploying nfpm with
|
| Latest commit: |
1965e83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae13cc0b.nfpm.pages.dev |
| Branch Preview URL: | https://issue-829.nfpm.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 73.01% 73.12% +0.10%
==========================================
Files 22 22
Lines 2487 2489 +2
==========================================
+ Hits 1816 1820 +4
+ Misses 464 463 -1
+ Partials 207 206 -1 ☔ View full report in Codecov by Sentry. |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forcefully set dirs owned by the FS as implicit dirs.
the rpm implementation should then not add them, which should be the right behavior I think.
this way these files will still be owned by the
filesystempackage instead of the package being built.this only affects
type: tree.also added logrotate to the list of "common" paths.
closes #829