Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpm doesnt allow dashes in prerelease #836

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: rpm doesnt allow dashes in prerelease #836

merged 1 commit into from
Jul 5, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 4, 2024

closes #835

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2024
@caarlos0 caarlos0 self-assigned this Jul 4, 2024
@caarlos0 caarlos0 added bug Something isn't working and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2024
Copy link

Deploying nfpm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 888e851
Status: ✅  Deploy successful!
Preview URL: https://8e1fbf30.nfpm.pages.dev
Branch Preview URL: https://rpmver.nfpm.pages.dev

View logs

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.01%. Comparing base (784fa6c) to head (888e851).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          22       22           
  Lines        2487     2487           
=======================================
  Hits         1816     1816           
  Misses        464      464           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickajacks1
Copy link
Contributor

Thanks! This fixes our issues.

@caarlos0 caarlos0 merged commit 250d102 into main Jul 5, 2024
46 of 48 checks passed
@caarlos0 caarlos0 deleted the rpmver branch July 5, 2024 14:25
@github-actions github-actions bot added this to the 2.38.0 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid RPM version strings when version contains multiple '-'
2 participants