fix(415): atOp's writeHash doesn't panic anymore

gorgonia · Jun 29, 2020 · 16dc78b · 16dc78b
1 parent 9f5ade0
commit 16dc78b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/op_tensor.go b/op_tensor.go
@@ -60,11 +60,7 @@ func (op atOp) Do(inputs ...Value) (retVal Value, err error) {
 }
 
 func (op atOp) WriteHash(h hash.Hash) {
-	fmt.Fprintf(h, "atOp")
-	if err := binary.Write(h, binary.LittleEndian, op.d); err != nil {
-		panic(err)
-	}
-	fmt.Fprintf(h, "at%v", op.coordinates)
+	fmt.Fprintf(h, "atOp%v%v", op.d, op.coordinates)
 }
 
 func (op atOp) Hashcode() uint32 { return simpleHash(op) }

diff --git a/op_tensor_test.go b/op_tensor_test.go
@@ -1,6 +1,7 @@
 package gorgonia
 
 import (
+	"crypto/sha256"
 	"runtime"
 	"testing"
 
@@ -345,3 +346,15 @@ func TestConcatOp(t *testing.T) {
 	assert.True(ValueEq(xG, aG))
 	assert.True(ValueEq(xx.Value(), aa.Value()))
 }
+
+func Test_atOp_WriteHash(t *testing.T) {
+	defer func() {
+		if r := recover(); r != nil {
+			t.Fail()
+		}
+	}()
+	h := sha256.New()
+
+	at := &atOp{}
+	at.WriteHash(h)
+}