Сorrected typos, fixed ineffassign, gofmt, go_vet #202
Conversation
solvers.go
Outdated
| @@ -1160,13 +1160,13 @@ func (s *BarzilaiBorweinSolver) Step(model Nodes) error { | |||
| contractionAxes[axis] = axis | |||
| } | |||
|
|
|||
| valGradDiffscalarProd, err := tensor.Contract(valueDiff, gradDiff, contractionAxes, contractionAxes) | |||
| valGradDiffscalarProd, _ := tensor.Contract(valueDiff, gradDiff, contractionAxes, contractionAxes) | |||
There was a problem hiding this comment.
This is not a good idea. @siquus how should errrors be handled for Barzilai Borwein. I'm going to guess the default is to return the error?
|
Thanks for this. More importantly thanks for finding a potential bug I have left a comment waiting @siquus' reply on how to handle errors. If he doesn't respond in 12 hrs, can you please fix it such that the err is not shadowed? Specifically, we try to make it such that no errors in Gorgonia is unhandled. The default way of handling error is to return early. |
|
@chewxy i will check what i can do if he not respond |
|
Thanks 👍 I'll merge this when ready. |
|
@trigun117 nice catch ...somebody... forgot to actually react to err ;-) |
|
@chewxy updated code |
|
LGTM. Merged |
No description provided.