Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when noasm tag is used #315

Closed
wants to merge 1 commit into from
Closed

Fix when noasm tag is used #315

wants to merge 1 commit into from

Conversation

bezineb5
Copy link
Contributor

@bezineb5 bezineb5 commented Sep 3, 2019

Compilation fails when noasm is used, as this method is not defined in that case.
This is a fix for #311

@bezineb5
Fix when noasm tag is used
8887215 
Compilation fails when noasm is used, as this method is not defined in that case
@chewxy
Copy link
Member

chewxy commented Sep 3, 2019

LGTM. I will add the noasm to the yaml as well

@bezineb5
Copy link
Contributor Author

bezineb5 commented Sep 3, 2019

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.895% when pulling 8887215 on bezineb5:patch-1 into 93e2388 on gorgonia:master.

@chewxy
Copy link
Member

chewxy commented Sep 3, 2019

See #316 . I wasn't able to add directly to this PR... but your contributions remain.

@chewxy chewxy closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bezineb5 @chewxy @coveralls