Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of example/iris #348

Merged
merged 1 commit into from Nov 1, 2019
Merged

Conversation

mattn
Copy link
Member

@mattn mattn commented Nov 1, 2019

Reuse x, y for getThetaNormal

@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage remained the same at 63.064% when pulling f7f2e75 on mattn:improve-iris into 6f8c10a on gorgonia:master.

@owulveryck owulveryck merged commit 6cc7466 into gorgonia:master Nov 1, 2019
@mattn mattn deleted the improve-iris branch November 2, 2019 01:10
chewxy added a commit that referenced this pull request Nov 18, 2019
commit 592126c
Author: Ben Leitner <7515022+bdleitner@users.noreply.github.com>
Date:   Sun Nov 17 15:09:08 2019 -0800

    Refactor the max/sum ops to share common code. Have the type/inferShape/Do methods behave in a consistent manner: (#346)

    * Dimensions specified in the "along" parameter are reduced to size 1, but not removed. (Note: this caused TestRepeatOpDoDiff, but this version fixes it.  Perhaps we should make preserving the size-1 dimensions an option of the reduction op?)
    * If all dimensions are included, the result will be a scalar.
    * If all dimensions but 1 are included, the result is a vector, regardless of which dimension is left intact.

    Tests verify that the resulting nodes have the expected shape.

    Note: While here, fix a warning on Max's SymDiff where retVal[0] is set when retVal has not been initialized.  I wonder if this is related to #323 where SymDiff for StableSoftMax (which uses Max) was failing with a panic (probably not, as the error message there seems unrelated, but probably a good fix anyway).

    Closes #326

commit 6fd05db
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Tue Nov 12 09:15:56 2019 +0100

    Examples/readme (#351)

    * chore(readme): add references to the gorgonia website

commit e6bc7dd
Merge: 9ecd7d0 d1d231f
Author: gareth <31232838+jokebroker@users.noreply.github.com>
Date:   Sat Nov 9 06:47:29 2019 +1100

    Merge pull request #350 from mattn/fix-gomod

    Fix go.mod

commit d1d231f
Author: Yasuhiro Matsumoto <mattn.jp@gmail.com>
Date:   Fri Nov 8 21:35:58 2019 +0900

    Fix go.mod

commit 9ecd7d0
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Thu Nov 7 09:59:37 2019 +0100

    Gap operator (#302)

    * feat(wip): scratch space for a Global Average Pooling operator

    * chore: skeleton of the operator

    * feat: Global Average Pool

commit 6cc7466
Author: mattn <mattn.jp@gmail.com>
Date:   Sat Nov 2 03:16:02 2019 +0900

    Improvement of example/iris (#348)

commit 6f8c10a
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Thu Oct 31 22:10:37 2019 +0100

    Iris example (#347)

    * fix: do not overwrite the channel if it already exists

    * feat: multivariate linear regression

commit b7b4b2c
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Wed Oct 16 15:34:26 2019 +0200

    Create FUNDING.yml (#342)
chewxy added a commit that referenced this pull request Dec 8, 2019
* Added KeepDims as an additional function to "decorate" another function
Cleaned up Ones and ones

* Added broadcasted operations to api_gen
Wrote program to generate those broadcasted ops
Renamed BroadcastMul to BroadcastHadamardProd. BroadcastMul is coming soon

* added an example to show how one may use the broadcasting operations to create dense triangular matrices

* Added better support for BatchedMatMul. Now more than 3D tensors are supported!

* Added unaryOp interface to genapi. Generating the interfaces makes the interfaces more consistent. Previously inversef32 gave the wrong ʘUnaryOperatorType

* Allow axis to be defined in SoftMax. Furthermore the default axis is now the last axis. This allows for SoftMax to be done across ndarrays
Added more examples

* Ported Unconcat to Gorgonia. Added tests

* Added some things for future

* Added more support functions for Golgi

* added some statistics generation for genapi

* Added monad-y error handling to Gorgonia

* Let's do away with the DoXXX functions

* Changed the definition of LiftResult a bit.

* added some helper functions

* Updated Unconcat tor use Nodes instead of []*Node
This allows for easier lifting of the return value, however its
utility is not known at the moment.

* Added HeEtAl InitWFn

* Ugh. Copy and pasting sux when you can only type with one hand

* Squashed commit of the following:

commit 592126c
Author: Ben Leitner <7515022+bdleitner@users.noreply.github.com>
Date:   Sun Nov 17 15:09:08 2019 -0800

    Refactor the max/sum ops to share common code. Have the type/inferShape/Do methods behave in a consistent manner: (#346)

    * Dimensions specified in the "along" parameter are reduced to size 1, but not removed. (Note: this caused TestRepeatOpDoDiff, but this version fixes it.  Perhaps we should make preserving the size-1 dimensions an option of the reduction op?)
    * If all dimensions are included, the result will be a scalar.
    * If all dimensions but 1 are included, the result is a vector, regardless of which dimension is left intact.

    Tests verify that the resulting nodes have the expected shape.

    Note: While here, fix a warning on Max's SymDiff where retVal[0] is set when retVal has not been initialized.  I wonder if this is related to #323 where SymDiff for StableSoftMax (which uses Max) was failing with a panic (probably not, as the error message there seems unrelated, but probably a good fix anyway).

    Closes #326

commit 6fd05db
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Tue Nov 12 09:15:56 2019 +0100

    Examples/readme (#351)

    * chore(readme): add references to the gorgonia website

commit e6bc7dd
Merge: 9ecd7d0 d1d231f
Author: gareth <31232838+jokebroker@users.noreply.github.com>
Date:   Sat Nov 9 06:47:29 2019 +1100

    Merge pull request #350 from mattn/fix-gomod

    Fix go.mod

commit d1d231f
Author: Yasuhiro Matsumoto <mattn.jp@gmail.com>
Date:   Fri Nov 8 21:35:58 2019 +0900

    Fix go.mod

commit 9ecd7d0
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Thu Nov 7 09:59:37 2019 +0100

    Gap operator (#302)

    * feat(wip): scratch space for a Global Average Pooling operator

    * chore: skeleton of the operator

    * feat: Global Average Pool

commit 6cc7466
Author: mattn <mattn.jp@gmail.com>
Date:   Sat Nov 2 03:16:02 2019 +0900

    Improvement of example/iris (#348)

commit 6f8c10a
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Thu Oct 31 22:10:37 2019 +0100

    Iris example (#347)

    * fix: do not overwrite the channel if it already exists

    * feat: multivariate linear regression

commit b7b4b2c
Author: Olivier Wulveryck <owulveryck@users.noreply.github.com>
Date:   Wed Oct 16 15:34:26 2019 +0200

    Create FUNDING.yml (#342)

* Fixed Softmax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants