Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt for a github action #419

Merged
merged 15 commits into from Jul 7, 2020
Merged

feat: attempt for a github action #419

merged 15 commits into from Jul 7, 2020

Conversation

owulveryck
Copy link
Member

@owulveryck owulveryck commented Jul 7, 2020

This action test with GOPATH on Linux amd64 This does not work
Then it test with gomodules on linux / darwin / amd64 / arm

This action test with GOPATH on Linux amd64
Then it test with gomodules on linux / darwin / amd64 / arm
@coveralls
Copy link

coveralls commented Jul 7, 2020

Coverage Status

Coverage remained the same at 64.588% when pulling 7492ca1 on devops into fe1839e on master.

@owulveryck
Copy link
Member Author

I propose this github action.
First it runs test for go 1.13. and go 1.14 and coverage for go 1.14 in parallel.
If tests are success, it runs a build on amd64 Linux and macos in parralel.

All the steps are completing before travis :D

WDYT?

@owulveryck owulveryck self-assigned this Jul 7, 2020
@blackrez
Copy link
Collaborator

blackrez commented Jul 7, 2020

Why use github actions instead of travis ?
Also you only test build on linux/amd64 because github actions doesn't support other architecture.

@blackrez
Copy link
Collaborator

blackrez commented Jul 7, 2020

We could add in the future a arm runner with hosted runner. Looks good to me https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

Copy link
Contributor

@jokebroker jokebroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm/makes sense

@jokebroker jokebroker merged commit fc5bf8e into master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants