Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom runner for arm64 #421

Merged
merged 8 commits into from
Jan 1, 2021
Merged

feat: add custom runner for arm64 #421

merged 8 commits into from
Jan 1, 2021

Conversation

blackrez
Copy link
Collaborator

@blackrez blackrez commented Jul 9, 2020

Add custom runner for arm

Add custom runner for arm
@blackrez blackrez requested a review from owulveryck July 9, 2020 19:52
@blackrez blackrez changed the title feat: add custom runner for arm64 [WiP] feat: add custom runner for arm64 Jul 9, 2020
@blackrez
Copy link
Collaborator Author

@chewxy @owulveryck Do we open issues for fixe the tests on arm before merge this PR ?

Copy link
Member

@owulveryck owulveryck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackrez blackrez changed the title [WiP] feat: add custom runner for arm64 feat: add custom runner for arm64 Jan 1, 2021
@blackrez
Copy link
Collaborator Author

blackrez commented Jan 1, 2021

The runner is ready to test the code. But some tests are still failing on ARM64.

@chewxy
Copy link
Member

chewxy commented Jan 1, 2021

Failing tests are due to numerical issues. Not a deal breaker. Merging.

@chewxy chewxy merged commit d1c6a19 into master Jan 1, 2021
@owulveryck owulveryck deleted the add-custom-runner branch February 23, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants