fix(concurrent example): process partial filled chunks too #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmang
commented
Feb 10, 2021
| @@ -149,7 +149,7 @@ func prep() (x, y Value, bs []batch) { | |||
| } | |||
|
|
|||
| func concurrentTraining(xV, yV Value, bs []batch, es int) { | |||
| threads := runtime.GOMAXPROCS(-1) // reserve one thread for the CPU locked thread | |||
There was a problem hiding this comment.
The comment was misleading. -1 doesn't change the current setting of max cpus.
https://golang.org/pkg/runtime/#GOMAXPROCS says, this call will go away, when scheduler improves, so I switched to NumCPU()
chrmang
commented
Feb 10, 2021
| @@ -80,7 +80,7 @@ func (t *concurrentTrainer) train(x, y Value, costChan chan cost, wg *sync.WaitG | |||
| func trainEpoch(bs []batch, ts []*concurrentTrainer, threads int) { | |||
| // costs := make([]float64, 0, len(bs)) | |||
| chunks := len(bs) / len(ts) | |||
| for chunk := 0; chunk < chunks; chunk++ { | |||
There was a problem hiding this comment.
It's a integer division. Due to the remainder we need a '<='.
owulveryck
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.